Skip to content

Switch to released lighthouse version#37

Merged
calebeby merged 3 commits intomasterfrom
released-lighthouse-version
Oct 2, 2020
Merged

Switch to released lighthouse version#37
calebeby merged 3 commits intomasterfrom
released-lighthouse-version

Conversation

@calebeby
Copy link
Member

@calebeby calebeby commented Oct 2, 2020

Closes #10

@calebeby calebeby requested a review from emersonthis October 2, 2020 17:16
@changeset-bot
Copy link

changeset-bot bot commented Oct 2, 2020

🦋 Changeset detected

Latest commit: dcbd591

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@emersonthis
Copy link

@calebeby thanks for doing this. Did you check to make sure the category score made it into that release? I'm not sure if our test coverage is sufficient to catch that...

@calebeby
Copy link
Member Author

calebeby commented Oct 2, 2020

@emersonthis I am seeing the "Performance: Overall Performance Category Score (numeric)" column if that is what you mean. The lighthouse release is from two days ago so it is more recent than the commit we were pinned to.

@calebeby calebeby merged commit b24d697 into master Oct 2, 2020
@calebeby calebeby deleted the released-lighthouse-version branch October 2, 2020 19:20
@github-actions github-actions bot mentioned this pull request Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update lighthouse dependency to official release version

2 participants