fix: Included rawPolicy for aws services#12
Merged
tyler-dunkel merged 1 commit intoalphafrom Apr 25, 2022
Merged
Conversation
mfranceschit
requested review from
csbrandt,
hjaraujof,
m-pizarro and
tyler-dunkel
tyler-dunkel
reviewed
Apr 7, 2022
| id: cuid(), | ||
| policy: formatIamJsonPolicy(bp.policy) | ||
| policy: formatIamJsonPolicy(bp.policy), | ||
| rawPolicy: bp.policy, |
Contributor
There was a problem hiding this comment.
I think this should be top level. Are there cases where there is more than one bucket policy? I only see one in the format function and @ckoning I dont believe is familiar with a case where there is more than one.
Contributor
Author
There was a problem hiding this comment.
I made the requested changes here. Although, these changes will change some rules.
mfranceschit
force-pushed
the
fix/CG-1074
branch
3 times, most recently
from
d1a629f to
e3db960
Compare
hjaraujof
approved these changes
Apr 18, 2022
Contributor
There was a problem hiding this comment.
LGTM. Merge conflicts need to be solved though, also keep in mind the fix for ec2
Contributor
|
This looks good to me, just needs conflicts resolved. |
tyler-dunkel
force-pushed
the
fix/CG-1074
branch
from
e3db960 to
6ee5cef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue tracker links
CG-1074
Changes/solution