feat: Add apiGatewayHttpApi (apiGatewayV2) and apiGatewayDomainName services#60
Merged
tyler-dunkel merged 4 commits intoalphafrom May 16, 2022
Merged
feat: Add apiGatewayHttpApi (apiGatewayV2) and apiGatewayDomainName services#60tyler-dunkel merged 4 commits intoalphafrom
tyler-dunkel merged 4 commits intoalphafrom
Conversation
| } | ||
|
|
||
| if (isEmpty(data)) { | ||
| resolve([]) |
Contributor
There was a problem hiding this comment.
++ maybe it makes more sense to work on the not empty case? i.e. if (!isEmpty(data)) { ... } resolve([])
Contributor
Author
There was a problem hiding this comment.
It could be. Now double validation is being done for the data and items, I think both ways look good, but I can change them if it's better for you.
Contributor
There was a problem hiding this comment.
im ok with how it is now so long as no bugs
tyler-dunkel
approved these changes
May 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue tracker links
Add links to any relevant tasks/stories/bugs/pagerduty/etc
Example - dummy TODO project
TODO-123
Changes/solution
How does this change address the problem?
Testing
Describe how the testing was done, plus evidence, if not covered by automated tests
Notes and considerations
Add any additional notes and/or considerations
Dependencies
_Add dependencies on any other PRs, if applicable