RD-6061 Provide get, update and delete commands for Secrets Providers#1448
Merged
3 commits merged intomasterfrom Nov 15, 2022
Merged
RD-6061 Provide get, update and delete commands for Secrets Providers#14483 commits merged intomasterfrom
3 commits merged intomasterfrom
Conversation
tehasdf
reviewed
Nov 14, 2022
|
|
||
| @providers.command( | ||
| name='update', | ||
| short_help='Update a already exists secrets provider', |
Contributor
There was a problem hiding this comment.
Suggested change
| short_help='Update a already exists secrets provider', | |
| short_help='Update an existing secrets provider', |
| @staticmethod | ||
| def connection_parameters(required=True, _help=None, default=None): | ||
| args = [ | ||
| '--connection_parameters', |
Contributor
There was a problem hiding this comment.
eh maybe let's make this --connection-parameters? underscores in arguments are a bit weird i think
| name='update', | ||
| short_help='Update a already exists secrets provider', | ||
| ) | ||
| @cfy.options.secret_provider_name |
Contributor
There was a problem hiding this comment.
I think .secret_provider_name doesn't exist? :)
Anyway, I think it'd be better to have the name (in update and in delete) be an argument rather than a flag, ie. @cfy.argument('secret-provider-name').
So that it's cfy sec prov del provider1 rather than cfy sec prov del --name provider1
ghost
requested a review
from
tehasdf
previously approved these changes
Nov 15, 2022
The other one was actually `Last-Modified: Mon, 19 Sep 2022 12:26:00 GMT` This is the proper URL now, and I'm gonna hardcode x86_64 (ie. no aarch support here), because this already hardcodes amd64 in the control file.
tehasdf
approved these changes
Nov 15, 2022
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.