Merged
Conversation
mateumann
approved these changes
May 8, 2023
ghost
approved these changes
May 8, 2023
tehasdf
added a commit
that referenced
this pull request
Jun 5, 2023
* pip-compile actual requirements.txt * CI/builds: use reqs.txt, not dev-reqs.txt
tehasdf
added a commit
that referenced
this pull request
Jun 5, 2023
* CYBL-1965 - Update log-bundles delete command (#1479) * RND-625 Compile requirements.txt (#1480) * pip-compile actual requirements.txt * CI/builds: use reqs.txt, not dev-reqs.txt * RND-623 Add --recursive for dep & depgroups delete (#1481) * RND-622 Add --recursive to `cfy uninstall` (#1482) * RND-622 Add --recursive to `cfy uninstall` * update the mock assertion * RND-681 Windows build: update python version (#1484) This is the same python zip that we use in for the agent * RND-681 windows build: rename python36.zip to python311.zip (#1485) Also same as in agent... * RND-681 windows build: update pip/wheel/setuptools (#1486) Upgrade all the build tools so that things like cryptography can be installed via wheel --------- Co-authored-by: Adrian Polanczyk <61688882+adrian-polanczyk-codilime@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idea of using something called "dev-requirements" for builds is... unclear.
Instead, compile a proper reqs.txt and use that for the built artifacts.
Also, pin urllib3 to a version that doesn't need appengine