WDR-35 Enable sorting by environment type#3052
Merged
YoniItzhak merged 8 commits intomasterfrom May 18, 2021
Merged
Conversation
tehasdf
previously approved these changes
May 18, 2021
tehasdf
previously approved these changes
May 18, 2021
tehasdf
approved these changes
May 18, 2021
YoniItzhak
added a commit
that referenced
this pull request
May 18, 2021
* WDR-35 Enable sorting by environment type * Always sort by the default sort
YoniItzhak
added a commit
that referenced
this pull request
May 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deployments cannot be sorted by
environment_typebecause it is defined as apropertyand not as aresource_fieldof the table.This PR fixes it by defining
environment_typeashybrid_property, which according to this line counts as aresource_field, and thus solves the issue.