RD-2411 dep-groups extend: also use display name from dsl, 6.0.0#3065
Merged
tehasdf merged 3 commits into6.0.0-buildfrom May 21, 2021
Merged
RD-2411 dep-groups extend: also use display name from dsl, 6.0.0#3065tehasdf merged 3 commits into6.0.0-buildfrom
tehasdf merged 3 commits into6.0.0-buildfrom
Conversation
instead of only looking at the template from the request (spec), also check the one in the dsl. Remember that the display name can contain intrinsic functions, and if it does, then we don't template anything.
check that the template from the dsl is used, but only if it's just a string
geokala
approved these changes
May 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ports #3063 to 6.0.0