Conversation
EarthmanT
force-pushed
the
RD-817-Manila-SDK
branch
from
32125ca to
b5f7d8f
Compare
AdarShaked
suggested changes
Dec 24, 2020
| 'Allowed share with this result: {0}'.format(result)) | ||
| return result | ||
|
|
||
| def deny(self, var): |
Contributor
There was a problem hiding this comment.
Can we think on informative name to var ? from what i see its an ip instance id
| openstack_resource.delete() | ||
|
|
||
| if openstack_resource.delete_failed: | ||
| raise NonRecoverableError('Failed to delete the resource {0}.'.format( |
Contributor
There was a problem hiding this comment.
Use keywords in format.
Collaborator
Author
There was a problem hiding this comment.
in this plugin people have used indices I think?
| raise NonRecoverableError('Failed to delete the resource {0}.'.format( | ||
| openstack_resource.resource_id)) | ||
| elif not openstack_resource.resource: | ||
| ctx.logger.info('Shared resource {0} is deleted successfully'.format( |
Collaborator
Author
There was a problem hiding this comment.
in this plugin people have used indices I think?
EarthmanT
force-pushed
the
RD-817-Manila-SDK
branch
from
b5f7d8f to
d3d173d
Compare
EarthmanT
force-pushed
the
RD-817-Manila-SDK
branch
from
15c34c3 to
8fb4f84
Compare
AdarShaked
previously approved these changes
Dec 24, 2020
EarthmanT
force-pushed
the
RD-817-Manila-SDK
branch
from
12f71d2 to
154e9e7
Compare
EarthmanT
force-pushed
the
RD-817-Manila-SDK
branch
from
154e9e7 to
8857961
Compare
AdarShaked
approved these changes
Dec 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.