RD-1897 - Add support for MANAGER_PROTOCOL environmental variable in Cypress configuration#53
Conversation
Contributor
Author
|
The solution used here is being tested using temporary branch from Results are promising: https://jenkins.cloudify.co/view/UI%20Health%20View/job/Stage-UI-System-Test/352/console |
kubama
reviewed
Mar 30, 2021
cypress/src/plugins/index.ts
Outdated
| config.baseUrl = `http://${process.env.MANAGER_IP}`; | ||
| const { MANAGER_IP, MANAGER_PROTOCOL } = process.env; | ||
| if (MANAGER_IP) { | ||
| config.baseUrl = `${MANAGER_PROTOCOL ?? 'http'}://${MANAGER_IP}`; |
Contributor
There was a problem hiding this comment.
Is plain HTTP still going to be supported?
Contributor
There was a problem hiding this comment.
SSL is opt-out, so I think yes 🙂
Contributor
Author
There was a problem hiding this comment.
Yes, it will still be possible to configure manager without SSL support.
From Lukasz M.: manager: security: ssl_enabled: false in config.yaml
kubama
previously approved these changes
Mar 30, 2021
Co-authored-by: Grzegorz Rozdzialik <grzegorz.rozdzialik@cloudify.co>
Gelio
approved these changes
Mar 30, 2021
kubama
approved these changes
Mar 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added new environmental variable for defining protocol used (
httporhttps). For backward compatibility defaulting tohttp.Once merged, I'll release new minor version of
cloudify-ui-commonand then updatecloudify-stageandcloudify-blueprint-composerwith the new version.