Skip to content

RD-6607: Updated screenshots after theming changes#2532

Merged
alexmolev merged 7 commits intomasterfrom
RD-6607
Mar 28, 2023
Merged

RD-6607: Updated screenshots after theming changes#2532
alexmolev merged 7 commits intomasterfrom
RD-6607

Conversation

@Vorbert-Kruk
Copy link
Copy Markdown
Contributor

@Vorbert-Kruk Vorbert-Kruk commented Mar 20, 2023

PR is about updating screenshots related to theming changes

As theming changes were quite extensive, I've used the strategy of going through every static/images/ui image to update it if the update would be needed and if I'd be able to recreate presented on the screenshot circumstances

Additional benefit to that strategy is the fact that I was able to remove screenshots which weren't used anywhere within this repo 🎉

@Vorbert-Kruk Vorbert-Kruk requested a review from qooban March 20, 2023 12:10
@Vorbert-Kruk Vorbert-Kruk marked this pull request as ready for review March 20, 2023 12:10
@Vorbert-Kruk Vorbert-Kruk requested a review from alexmolev March 20, 2023 13:20
Copy link
Copy Markdown
Contributor

@qooban qooban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good 👍🏻 I really appreciate hard work of going over this big amount of screenshots.

I've got just one - general comment: I see you are lucky man using 4K display ;-) But looking at stats we probably won't benefit much from it yet and also image file sizes are bigger than before. AFAIR Hugo (at least with current configuration) is not compressing images, it just shows them as is.

What do you think about rescaling images (e.g. 50%)? There are probably some tools to do mass rescale on a list of images. Or maybe there's Hugo configuration to do that automagically? 🤔

@Vorbert-Kruk
Copy link
Copy Markdown
Contributor Author

Vorbert-Kruk commented Mar 23, 2023

I've got just one - general comment: I see you are lucky man using 4K display ;-) But looking at stats we probably won't benefit much from it yet and also image file sizes are bigger than before. AFAIR Hugo (at least with current configuration) is not compressing images, it just shows them as is.

What do you think about rescaling images (e.g. 50%)? There are probably some tools to do mass rescale on a list of images. Or maybe there's Hugo configuration to do that automagically? 🤔

I was just cutting out some pieces of screenshots made on Dell's laptop
As those are appearing in 4k, I'm impressed 😄
Probably the display is 1920x1024, but the resolution is 2x - that's why 4K effect may be visible, as the pixels are being automatically scalled 🤔

Anyway, I think that the proposition about rescaling images is a valid one
Because of that, I've took the opportunity to learn how to scale bunch of images in a simple way 🎉
And the results are quite satisfying, so if in the future anybody would wonder how to perform those type of actions on Windows, I'll be happy to help :)

Images were resized within eb65d97 🎸

@Vorbert-Kruk Vorbert-Kruk requested a review from qooban March 23, 2023 11:11
Copy link
Copy Markdown
Contributor

@qooban qooban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍🏻

@alexmolev alexmolev merged commit 679a063 into master Mar 28, 2023
@alexmolev alexmolev deleted the RD-6607 branch March 28, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants