Skip to content

Drop support for Python 2.6, 3.2 and 3.3, as per wheel's official sup…#111

Merged
nir0s merged 7 commits intomasterfrom
drop-py26-support
Nov 28, 2017
Merged

Drop support for Python 2.6, 3.2 and 3.3, as per wheel's official sup…#111
nir0s merged 7 commits intomasterfrom
drop-py26-support

Conversation

@nir0s
Copy link
Copy Markdown
Contributor

@nir0s nir0s commented Oct 12, 2017

…port

  • Drop support for python versions not supported by the latest version of wheel (2.6, 3.2, 3.3).
  • State that in the README.
  • State in the README that to use Wagon in 2.6, 3.2 and 3.3, you should use v0.6.1 and below.

@nir0s nir0s requested a review from mxmrlv October 12, 2017 17:08
@nir0s
Copy link
Copy Markdown
Contributor Author

nir0s commented Oct 12, 2017

@funkyHat @mcouthon

Comment thread .travis.yml Outdated
env: TOXENV=py26
- python: 2.7
env: TOXENV=py27
- python: 3.3
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this 3.3 stuff be removed too?

Comment thread setup.py
classifiers=[
'Development Status :: 4 - Beta',
'Programming Language :: Python',
'Programming Language :: Python :: 2.6',
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add this?

'Programming Language :: Python :: 2',

@hugovk
Copy link
Copy Markdown

hugovk commented Oct 20, 2017

By the way, here's the pip installs for wagon from PyPI for the last month, showing low numbers for 2.6 and none for 3.2 or 3.3:

$ pypinfo --percent --pip wagon pyversion
python_version percent download_count
-------------- ------- --------------
2.7              76.7%          5,505
3.4              21.0%          1,511
2.6               2.1%            152
3.6               0.1%              7
3.5               0.0%              3
3.7               0.0%              1

@nir0s
Copy link
Copy Markdown
Contributor Author

nir0s commented Oct 22, 2017

Good point @hugovk. I'll address this. @mxmrlv, are we going to address this PR?

Comment thread setup.py Outdated
from setuptools import setup

if sys.version_info[:2] < (2, 7):
# TODO: Replace with `python_requires` in `setup`
Copy link
Copy Markdown

@hugovk hugovk Nov 28, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we go:

python_requires='>=2.7,!=3.0.*,!=3.1.*,!=3.2.*,!=3.3.*',

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hehe. wonderful.

@nir0s nir0s merged commit b509a8d into master Nov 28, 2017
@nir0s nir0s deleted the drop-py26-support branch November 28, 2017 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants