41 properly format pip install path on windows#45
Merged
Conversation
it appears that on Windows based platforms the default pip install path(for Python < 2.7.9) is C:\Python27\Scripts however wagon assumed it is located along-side python inside os.path.dirname(sys.executable) which is C:\Python27 and therefore failed to work on Windows based platforms. this patch resolves that issue. Note that when in a virtualenv, wagon will try to provide the virtual env path so that pip is found in the correct path
nir0s
force-pushed
the
41-properly-format-pip-install-path-on-windows
branch
from
14b770c to
c059b54
Compare
Contributor
Author
|
Solves #41 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it appears that on Windows based platforms the default pip install path(for Python < 2.7.9) is C:\Python27\Scripts however wagon assumed it is located along-side python inside os.path.dirname(sys.executable) which is C:\Python27 and therefore failed to work on Windows based platforms.
this patch resolves that issue.