Skip to content

next/future/image#3

Merged
colbyfayock merged 9 commits intomainfrom
future-image
Oct 27, 2022
Merged

next/future/image#3
colbyfayock merged 9 commits intomainfrom
future-image

Conversation

@colbyfayock
Copy link
Collaborator

No description provided.

@vercel
Copy link

vercel bot commented Sep 20, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
next-cloudinary ✅ Ready (Inspect) Visit Preview Oct 27, 2022 at 8:25PM (UTC)

@colbyfayock
Copy link
Collaborator Author

https://github.com/all-contributors please add @colbyfayock for code, doc, example

@colbyfayock
Copy link
Collaborator Author

@all-contributors please add @colbyfayock for code, doc, example

@allcontributors
Copy link
Contributor

@colbyfayock

I've put up a pull request to add @colbyfayock! 🎉

@nucliweb
Copy link
Contributor

What do you think about defining a prop to use next/future/image or next/image.
There are a lot of legacy projects with the next/image still.

@colbyfayock
Copy link
Collaborator Author

so, my thinking here is because of the way i'm wrapping the component, CldImage doesn't necessarily care what version the component is using

i have to test to confirm this, but nothing i'm doing is using anything that's changed, it all gets passed through, and i add stuff on top by making modifications to the src based on additional Cloudinary-related props

@nucliweb
Copy link
Contributor

nucliweb commented Oct 20, 2022

Yes, but if I want to use CldImage component but I use the Next.js version lower than 12.3 (with support to next/future/image) I will have a crash, right?

@colbyfayock
Copy link
Collaborator Author

i need to test that theory and see (or if you want to help out with that). its my understanding next/future/image will be updated to next/image in the release, it won't maintain /future so it will treat it the same, it will just have a different API

i have Next.js as a peer dependency, so there shoudln't be any version requirements iif im not mistaken

@nucliweb
Copy link
Contributor

@colbyfayock FYI, Next.js 13 will be remove /future from the component name.

github-actions bot pushed a commit that referenced this pull request Oct 27, 2022
# [0.4.0](v0.3.0...v0.4.0) (2022-10-27)

### Features

* next/future/image ([#3](#3)) ([9c271ef](9c271ef))
@github-actions
Copy link

🎉 This PR is included in version 0.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

lytro-dev pushed a commit to lytro-dev/next-image-delivery that referenced this pull request Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants