use pointer instead of value for http.Client #111
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Summary of Changes
Modified the
Clientfield inadmin.APIanduploader.APIstructs to be a pointer (*http.Client) instead of a value (http.Client). The corresponding initialization inNewWithConfigurationnow uses the sharedhttp.DefaultClientinstead ofhttp.Client{}.What does this PR address?
Are tests included?
Reviewer, please note:
This refactoring aligns
http.Clientusage with Go best practices. By using a pointer (*http.Client) and initializing withhttp.DefaultClient, we ensure efficient HTTP connection pooling via the underlying transport and better resource management, especially under load. No functional change is expected when using the default client, but resource utilization is improved.Checklist: