Merged
Conversation
adimiz1
requested review from
const-cloudinary,
lbendavid-cloudinary and
pawelphilipczyk-cloudinary
const-cloudinary
requested changes
Jul 21, 2023
| console.log(error) | ||
| expect(response).toBeDefined(); // Assert that the response matches the mock response | ||
| }); | ||
| // const fileToSend = await RNFS.readFile('__tests__/.resources/logo.png') |
Member
There was a problem hiding this comment.
Please remove unused comments
| filename: string; | ||
| headers: [string: any]; | ||
| params: [string: any]; | ||
| //payload: |
Member
There was a problem hiding this comment.
Please remove unused comments
| @@ -0,0 +1,696 @@ | |||
| import { Transform } from 'stream'; | |||
Member
There was a problem hiding this comment.
If you took it from other repo, please add a comment saying where this file is taken from, it will require sync from time to time.
| return data; | ||
| } | ||
|
|
||
| export async function explicit(cloudinary: Cloudinary, {public_id , options = {}, config = null, callback}: {public_id: string, options?: UploadApiOptions,config: APIConfig | null, callback?: UploadResponseCallback}) { |
Member
There was a problem hiding this comment.
I would separate public apis from internal utils
example/src/App.tsx
Outdated
| ); | ||
| } | ||
|
|
||
| // async function uploadImage() { |
Member
There was a problem hiding this comment.
Please finalize the sample file. Keep only relevant examples and remove irrelevant comments.
const-cloudinary
approved these changes
Jul 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Summary of Changes
This PR adds the upload API, including upload, rename and explicitly API's
Tests are yet to come.
What does this PR address?
Are tests included?
Reviewer, please note:
Checklist: