feat: use rollup for esm#1004
Merged
tsi merged 9 commits intofeat/schedule-lazy-playerfrom Mar 18, 2026
Merged
Conversation
✅ Deploy Preview for cld-vp-esm-pages ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for cld-video-player ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
adimiz1
approved these changes
Mar 17, 2026
src/utils/schedule.js
Outdated
Contributor
There was a problem hiding this comment.
The else branch on line 146 (if (startMin > endMin)) is dead code — since endMin = startMin + duration * 60 and duration is validated to be > 0 on the line above
Collaborator
Author
There was a problem hiding this comment.
Thanks, it was a bad attempt to handle multi-day time-slots. Handled it in the scheduler branch by adding a unified way to handle weekly time-ranges that supports over-night slots
tsi
added a commit
that referenced
this pull request
Mar 19, 2026
* feat: schedule and lazy-player * chore: style loading * chore: player * chore: move to duration based schedule * chore: handle over-night ranges * feat: use rollup for esm (#1004) * feat: use rollup for esm * chore: cleanup * chore: rollup imports * chore: build * chore: deduplicate * chore: setupCloudinaryGlobal * chore: test over-night time-ranges * chore: improve E2E test pages * chore: fix tests build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.