Skip to content

fix: respect poster for html#1009

Merged
tsi merged 4 commits intomasterfrom
fix/respect_html_poster
Mar 31, 2026
Merged

fix: respect poster for html#1009
tsi merged 4 commits intomasterfrom
fix/respect_html_poster

Conversation

@adimiz1
Copy link
Copy Markdown
Contributor

@adimiz1 adimiz1 commented Mar 24, 2026

  • Respect the native poster attribute on vide tags — the SDK no longer overwrites it with a generated
    poster
    • Detect child elements inside
    • Add poster: "html" API option to explicitly preserve the HTML poster
    • Fix extension truncation for external poster URLs in ImageSource (e.g., poster.jpg was becoming poster)

@adimiz1 adimiz1 requested a review from a team as a code owner March 24, 2026 17:05
@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 24, 2026

Deploy Preview for cld-video-player ready!

Name Link
🔨 Latest commit 07012ef
🔍 Latest deploy log https://app.netlify.com/projects/cld-video-player/deploys/69cbb575ac85d40008aaf221
😎 Deploy Preview https://deploy-preview-1009--cld-video-player.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 24, 2026

Deploy Preview for cld-vp-esm-pages ready!

Name Link
🔨 Latest commit 07012ef
🔍 Latest deploy log https://app.netlify.com/projects/cld-vp-esm-pages/deploys/69cbb5753d2abf00083fdc4f
😎 Deploy Preview https://deploy-preview-1009--cld-vp-esm-pages.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Comment thread src/plugins/cloudinary/models/image-source.js Outdated
@adimiz1 adimiz1 requested a review from tsi March 25, 2026 09:02
Copy link
Copy Markdown
Collaborator

@tsi tsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@tsi tsi merged commit 91951d6 into master Mar 31, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants