Skip to content

fix: cloudinary config is always undefined #1020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jakub-roch merged 2 commits into from
Apr 2, 2026
Merged

fix: cloudinary config is always undefined #1020

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd85a1c
fix: cloudinary config is always undefined
jakub-roch Apr 2, 2026
c34d81a
fix: cloudinaryConfig
jakub-roch Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion src/utils/fetch-config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
import pick from 'lodash/pick';
import { defaultProfiles } from 'cloudinary-video-player-profiles';
import { isRawUrl, getCloudinaryUrlPrefix } from '../plugins/cloudinary/url-helpers';
import { CLOUDINARY_CONFIG_PARAM } from '../video-player.const';
import { utf8ToBase64 } from '../utils/utf8Base64';
import { appendQueryParams } from './querystring';
import { convertKeysToSnakeCase } from './object';

const isDefaultProfile = (profileName) => !!defaultProfiles.find(({ name }) => profileName === name);

Expand All @@ -15,13 +18,23 @@ const getDefaultProfileConfig = (profileName) => {
return profile.config;
};

const getCloudinaryConfigFromOptions = (options) => {
if (options.cloudinaryConfig) {
return options.cloudinaryConfig;
}

const snakeCaseCloudinaryConfig = pick(convertKeysToSnakeCase(options), CLOUDINARY_CONFIG_PARAM);
return Object.assign({}, snakeCaseCloudinaryConfig);
};

const fetchConfig = async (options) => {
const { profile, publicId, cloudinaryConfig, type = 'upload', videoConfig, allowUsageReport = true } = options;
const { profile, publicId, type = 'upload', videoConfig, allowUsageReport = true } = options;

if (profile && isDefaultProfile(profile)) {
return getDefaultProfileConfig(profile);
}

const cloudinaryConfig = getCloudinaryConfigFromOptions(options);
const urlPrefix = getCloudinaryUrlPrefix(cloudinaryConfig) + '/_applet_/video_service';
const queryParams = allowUsageReport ? { _s: `vp-${VERSION}` } : null;

Expand Down
Loading