Merged
Conversation
✅ Deploy Preview for cld-video-player ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for cld-vp-esm-pages ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
adimiz1
approved these changes
May 4, 2026
Contributor
adimiz1
left a comment
adimiz1
left a comment
There was a problem hiding this comment.
No test added for new header/refresh-conditional behavior, maybe it's worth adding one?
| const wrapper = videojs.dom.createEl('div', { className: 'cld-error-display-content' }); | ||
| const msg = videojs.dom.createEl('span', { className: 'cld-error-message' }); | ||
| const header = videojs.dom.createEl('div', { className: 'cld-error-header' }); | ||
| const title = videojs.dom.createEl('span', { className: 'cld-error-title' }, {}, this.localize('Something went wrong')); |
Contributor
There was a problem hiding this comment.
Something went wrong - should be hardcoded?
Collaborator
Author
There was a problem hiding this comment.
I wanted some generic title, so a default one must be hard-coded, but we can allow it to be configured I guess
| const wrapper = videojs.dom.createEl('div', { className: 'cld-error-display-content' }); | ||
| const msg = videojs.dom.createEl('span', { className: 'cld-error-message' }); | ||
| const header = videojs.dom.createEl('div', { className: 'cld-error-header' }); | ||
| const title = videojs.dom.createEl('span', { className: 'cld-error-title' }, {}, this.localize('Something went wrong')); |
Contributor
There was a problem hiding this comment.
Is cld-error-title needed here? I could not find it in code
Collaborator
Author
There was a problem hiding this comment.
wdym? we give this class to the "Something went wrong" span
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves the Cloudinary Video Player error overlay so errors render as a centered, themed message instead of the previous flat gray block. Adds a dedicated title, message area, and retry action wired to the existing refresh event.
Changes
Something went wrongheading and localized error message body.Try Againaction when the error message does not already provide a.cld-error-refreshlink.Visuals
UI styling changed for player error states. Please attach before/after screenshots or verify the error overlay visually before review.
Before:
After: