Refactor code#38
Conversation
|
I have read the code, checked-out onto the branch. However the tests have one issue - you're using I also created a branch and a PR that added test for SSR - I have merged that onto your branch, added CldTransformation to that (cause I made the test for a repo state where it is removed) and that also failed. This unfortunately brings the repo state to before I see you have removed I didn't made utils into a single file to have a clear overview of what functions I have. I try to include single concept into a file. That might mean different things in JS unlike for example Java where that would mean a class - a function, a class, a module (set of functions that are connected with their purposes). Separating functions into files also prevents unused code to be included into a resulting bundle. I'd prefer you to explain why you changed it, so I can understand it and apply it in the future changes. |
uniq,union,extractOptions)utilsStateandChannelclass, switch to useprovide/inject.CldTransformation