Skip to content

Add analytics feature flag #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adimiz1 merged 2 commits into from
Feb 18, 2024
Merged

Add analytics feature flag #165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
86034dd
Add analytics feature flag
adimiz1 Feb 18, 2024
cb8c7b0
Fix setting analytics
adimiz1 Feb 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/main/java/com/cloudinary/android/MediaManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ private MediaManager(@NonNull Context context, @Nullable SignatureProvider signa
if (cloudinary.config.analytics == null) {
cloudinary.config.analytics = true;
}
cloudinary.setAnalytics(new Analytics("F", VERSION, techVersion, "A", techVersion));
cloudinary.setAnalytics(new Analytics("F", VERSION, techVersion, "A", techVersion, "0"));

// set https as default for all http requests
cloudinary.config.secure = true;
Expand Down
2 changes: 1 addition & 1 deletion gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ developerEmail=info@cloudinary.com
# These two properties must use these exact names to be compatible with 'gradle install' plugin.
group=com.cloudinary
version=2.7.1
cloudinaryLibsVersion=1.37.0
cloudinaryLibsVersion=1.38.0

org.gradle.jvmargs=-Xmx1024m
gnsp.disableApplyOnlyOnRootProjectEnforcement=true
Expand Down
3 changes: 2 additions & 1 deletion ui/src/main/java/com/cloudinary/android/cldvideoplayer/CldVideoPlayer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,14 +43,15 @@ public CldVideoPlayer(Context context, String publicId, Transformation transform
}

private void initiliaze(Context context, String publicId, Transformation transformation, Boolean automaticStreamingProfile) {
MediaManager.get().getCloudinary().analytics.setFeatureFlag("F");
if (automaticStreamingProfile && transformation == null) {
transformation = new Transformation();
transformation.streamingProfile("auto");
this.url = MediaManager.get().url().resourceType("video").transformation(transformation).format("m3u8").generate(publicId);
} else {
this.url = MediaManager.get().url().resourceType("video").transformation(transformation).generate(publicId);
}

MediaManager.get().getCloudinary().analytics.setFeatureFlag("0");
initPlayer(context, url);
}

Expand Down