Conversation
const-cloudinary
requested changes
Mar 17, 2024
| assert cldVideoPlayer[0].getPlayer() != null; | ||
| assert cldVideoPlayer[0].getUrl().contains("publicId.m3u8"); | ||
| assert cldVideoPlayer[0].getUrl().contains("sp_auto"); | ||
| assert cldVideoPlayer[0].getUrl().contains("publicId"); |
There was a problem hiding this comment.
maybe change to endsWith or something. Obviously "publicId.m3u8" contains "publicId"
Contributor
Author
There was a problem hiding this comment.
We can sense there is also the analytics token
We can disable the analytics token and then try endsWith if it's important
There was a problem hiding this comment.
so maybe let's just verify that it does not contain .m3u8
const-cloudinary
approved these changes
Mar 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Summary of Changes
Remove
sp_autoby default fromCLDVideoPlayerWhat does this PR address?
Are tests included?
Reviewer, please note:
Checklist: