Fixed placeholder when user passes css style #284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrick-tolosa
approved these changes
Jul 14, 2020
| des = fixture.debugElement.queryAll(By.directive(CloudinaryImage)); | ||
| }); | ||
|
|
||
| it('should have style opacity and position when style is passed', () => { |
Contributor
There was a problem hiding this comment.
Maybe also add a check that the style that was passed exists? (check that we didn't discard the passed value)
Contributor
Author
There was a problem hiding this comment.
alright will update
Contributor
|
@strausr , please add a description to the PR, providing the required context for being able to review it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the style is passed into cl-image by the user it overwrites the placeholder image's style of position: absolute opacity 0. This causes the placeholder to jump out of place.
This fix comes to ensure that the placeholder style is reserved only when the placeholder is in view while keeping the passed in style values.