Conversation
src/tags/clienthintsmetatag.js
Outdated
| var ClientHintsMetaTag = class ClientHintsMetaTag extends HtmlTag { | ||
| /** | ||
| * Creates an HTML (DOM) Meta tag that enables client-hints. | ||
| * Creates an HTML (DOM) Meta tag that enables Client-Hints for the HTML page. <br/> |
There was a problem hiding this comment.
Missing parameter options in the doc comment
| * @see <a href="https://cloudinary.com/documentation/image_transformation_reference" | ||
| * target="_blank">Available image transformations</a> | ||
| * @see <a href="https://cloudinary.com/documentation/video_transformation_reference" | ||
| * target="_blank">Available video transformations</a> |
There was a problem hiding this comment.
Missing parameter options in the doc comment.
src/cloudinary.js
Outdated
| * var cl = new cloudinary.Cloudinary( { cloud_name: "mycloud"}); | ||
| * var imgTag = cl.image("myPicID"); | ||
| */ | ||
| * Main class for accessing Cloudinary functionality. |
src/configuration.js
Outdated
|
|
||
| /** | ||
| * Defaults configuration. | ||
| * Default configuration. |
There was a problem hiding this comment.
original meaning was "a configuration object that serves default values", hence the plural tense. If we change it, it should be to something like "A configuration for the various SDK functions"...
jackieros
left a comment
jackieros
left a comment
There was a problem hiding this comment.
In an attempt to just fix the couple of helpstring changes you made in your commits, I came across a bunch of helpstrings throughout that are missing periods.
Started fixing here, but makes more sense to do a global review locally and commit. Will ask @MeirFeinberg to fix alongside the other items he's supposed to handle.
Co-Authored-By: jackieros <jackie@cloudinary.com>
3 participants
No description provided.