Fix normalize_expression when variable is named like a keyword (e.g., "$width") #219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YomesInc
changed the title
patrick-tolosa
approved these changes
Apr 22, 2020
ghost
reviewed
May 5, 2020
ghost
approved these changes
May 5, 2020
ghost
deleted the
fix/normalize-expression-should-ignore-predefined-variables
branch
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
normalize_expression()will no longer transform predefined variables into their shortened form if they are preceded by an ampersand (meaning they are variables).For example:
$widthwill not be transformed into$w.💡 Note our comments in the PR for
cloudinary_npmwhich would also apply here. The solution proposed here will not work on old browsers that do not support lookbehind in regular expressions.