Ensure sources are an array in srcset hook. #1020
Conversation
tharsheblows
left a comment
tharsheblows
left a comment
There was a problem hiding this comment.
One question about the position of the array check.
php/class-media.php
Outdated
| } | ||
|
|
||
| // Handle unexpected sources variable type. | ||
| if ( ! is_array( $sources ) ) { |
There was a problem hiding this comment.
❓question
Does $sources ever come into this as eg an empty string and then go through and get set via the metadata? Just below this there is a check on the a lot of the metadata to set it where $sources is set.
The check should happen after that I think, from that point on it's assuming $sources is an array
There was a problem hiding this comment.
@tharsheblows Technically, $sources should never be anything else than an array:
The hook clearly documents $sources should always be an array. The intent here was just safeguard against emitting a PHP warning in case something unexpected happens and $sources comes in as a non-array (as it does on one of the customers' site).
Having said that, I do agree with you that it's smarter to move the check after we've inspected post meta as it's entirely possible we'll end up resetting $sources there. Making the change.
No description provided.