Skip to content

Ensure sources are an array in srcset hook. #1020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 11, 2025
Merged

Ensure sources are an array in srcset hook. #1020

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56d92b5
Ensure sources are an array in srcset hook.
dero Mar 3, 2025
3fe0646
Move the sources array check.
dero Mar 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions php/class-media.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1874,6 +1874,7 @@ public function image_srcset( $sources, $size_array, $image_src, $image_meta, $a
if ( ! $cloudinary_id ) {
return $sources; // Return WordPress default sources.
}

// Get transformations if any.
$transformations = Relate::get_transformations( $attachment_id );

Expand Down Expand Up @@ -1925,6 +1926,11 @@ function ( $item ) use ( $crop ) {
}
}

// Handle unexpected sources variable type.
if ( ! is_array( $sources ) ) {
return $sources;
}

// Add the main size as the largest srcset src.
$crop = $this->get_crop_from_transformation( $transformations );
if ( ! empty( $crop ) ) {
Expand Down