replace old URL in content for other instances of the local URL #212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dugajean
reviewed
Sep 22, 2020
| } | ||
| } | ||
|
|
||
| $content = str_replace( $asset, $new_tag, $content ); |
Contributor
There was a problem hiding this comment.
This could be simplified to
Suggested change
| $content = str_replace( $asset, $new_tag, $content ); | |
| $content = str_replace( array( $asset, $url ), array( $new_tag, $cloudinary_url ), $content ); |
dugajean
reviewed
Sep 22, 2020
|
|
||
| $content = str_replace( $asset, $new_tag, $content ); | ||
| // Additional URL change for backgrounds etc.. | ||
| $content = str_replace( $url, $cloudinary_url, $content ); |
Contributor
There was a problem hiding this comment.
If the change suggested above is used, this line can be removed 😄
dugajean
approved these changes
Sep 22, 2020
Contributor
dugajean
left a comment
dugajean
left a comment
There was a problem hiding this comment.
Left a minor potential improvement which is not mandatory. Good catch with this!
pereirinha
approved these changes
Sep 23, 2020
Contributor
pereirinha
left a comment
pereirinha
left a comment
There was a problem hiding this comment.
This looks good to me. I agree with @dugajean suggestion, but not required.
I'm merging for the time being.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.