Skip to content

replace old URL in content for other instances of the local URL #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2020
Merged

replace old URL in content for other instances of the local URL #212

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions cloudinary-image-management-and-manipulation-in-the-cloud-cdn/php/media/class-filter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,6 +378,8 @@ public function filter_out_local( $content ) {
}

$content = str_replace( $asset, $new_tag, $content );
Copy link
Contributor

@dugajean dugajean Sep 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be simplified to

Suggested change
$content = str_replace( $asset, $new_tag, $content );
$content = str_replace( array( $asset, $url ), array( $new_tag, $cloudinary_url ), $content );

// Additional URL change for backgrounds etc..
$content = str_replace( $url, $cloudinary_url, $content );
Copy link
Contributor

@dugajean dugajean Sep 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the change suggested above is used, this line can be removed 😄

}

return $this->filter_video_shortcodes( $content );
Expand Down