Skip to content

Conversation

@patrick-tolosa
Copy link
Contributor

@patrick-tolosa patrick-tolosa commented Jul 18, 2021

Pull request for @Cloudinary/Base

What does this PR solve?

This PR incorporates the code generation configuration into the project.
No functional changes were made regarding the behaviour of Base itself.

As an aside, added a private property to Gravity to force type coercion (Without this property, the object has no shape since it has no properties, and it passes all type validations)

What was done:

  1. Add .code-generation/config.js to the project
  2. Add a set of compilation tests as part of the project.
  3. Remove ^ from a couple of versions relevant for the reference website
  4. Fix some tests regarding Gravity.compass() (We used invalid gravities in some tests)

@patrick-tolosa patrick-tolosa requested a review from strausr July 18, 2021 17:20
@patrick-tolosa patrick-tolosa merged commit 97a0b79 into master Jul 19, 2021
@patrick-tolosa patrick-tolosa deleted the feature/code-generation branch July 19, 2021 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants