Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Aug 25, 2021

This pr fixes how lodash.cloneDeep is imported:

  1. import once using import cloneDeep from 'lodash.clonedeep'
  2. wrap in a function, so that lodash won't be imported directly incorrectly in other places, and make it so that replacing cloneDeep implementation won't require updating imports.

@ghost ghost requested review from patrick-tolosa and strausr August 25, 2021 06:58
@ghost ghost removed the request for review from strausr August 25, 2021 09:08
@ghost ghost merged commit 41dbf2a into master Aug 25, 2021
@ghost ghost deleted the fix/lodash-dependency branch August 25, 2021 12:54
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants