Skip to content

Conversation

@patrick-tolosa
Copy link
Contributor

@patrick-tolosa patrick-tolosa commented Sep 12, 2021

Pull request for @cloudinary/url-gen

  • FIx various expression normalization issues that were accidentally migrated from the old V1 SDK.

What does this PR solve?

  • Prevent multiple spaces from being normalized to a single _
  • Prevent multiple _ from being normalized to a single _
  • Add deep tests for the Expression function
  • Add a test for namedTransformation to ensure an old legacy bug isn't carried over.
  • Removed some es-lint rules that made it really annoying to work on the project.

Final checklist

  • Implementation is aligned to Spec.
  • Tests - Add proper tests to the added code.

@patrick-tolosa patrick-tolosa requested review from a user and strausr September 12, 2021 15:37
@patrick-tolosa patrick-tolosa marked this pull request as draft September 12, 2021 15:52
@patrick-tolosa patrick-tolosa removed request for a user and strausr September 12, 2021 15:52
@patrick-tolosa patrick-tolosa marked this pull request as ready for review September 13, 2021 11:24
@patrick-tolosa patrick-tolosa merged commit d2f81e1 into master Sep 14, 2021
@patrick-tolosa patrick-tolosa deleted the feature/adjust-expression-normalization branch September 14, 2021 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants