Initial structure#2
Merged
rajikaimal merged 9 commits intocloudlibz:masterfrom Jul 3, 2019
Merged
Conversation
2. Implement Json Web Token
rajikaimal
requested changes
Jun 26, 2019
Member
rajikaimal
left a comment
rajikaimal
left a comment
There was a problem hiding this comment.
Format all code with Prettier
| @@ -0,0 +1,19 @@ | |||
| var express = require("express"); | |||
Member
There was a problem hiding this comment.
Let's use const and let for all variable declarations.
| require('dotenv').config(); | ||
|
|
||
|
|
||
| module.exports = { |
rajikaimal
requested changes
Jun 27, 2019
Member
rajikaimal
left a comment
rajikaimal
left a comment
There was a problem hiding this comment.
Let's rename node-backend to server.
2. Send the selected service provider from front end 3. node-backend renamed to server
Design improvements
rajikaimal
reviewed
Jun 29, 2019
Member
rajikaimal
left a comment
rajikaimal
left a comment
There was a problem hiding this comment.
Let's rename react-frontend to client
Member
|
@amrita019 Please rename react-frontend to client. |
2. Design Navigation Bar in dashboard 3. Add an option to create service in nav bar which inflates modal in return 4. WIP: Create API endpoint for create service
rajikaimal
requested changes
Jul 3, 2019
| body: JSON.stringify(user) | ||
| }; | ||
|
|
||
| return fetch(`http://localhost:4000/signup`, requestOptions).then( |
Member
There was a problem hiding this comment.
Let's move URLs to a different file.
rajikaimal
requested changes
Jul 3, 2019
| @@ -0,0 +1,26 @@ | |||
| let express = require("express"); | |||
Member
There was a problem hiding this comment.
Change these variables to const
2. Changed occurences of let to const
rajikaimal
approved these changes
Jul 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.