fix(instance): improve error handling for RefreshSecrets#7260
Merged
Conversation
Contributor
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
cnpg-bot
added
backport-requested ◀️
Contributor
|
❗ By default, the pull request is configured to backport to all release branches.
|
Contributor
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
3 similar comments
Contributor
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
Contributor
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
Contributor
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
armru
force-pushed
the
dev/reconciler-refactor
branch
from
8a92701 to
f522cd1
Compare
leonardoce
force-pushed
the
dev/reconciler-refactor
branch
from
f522cd1 to
de2cf87
Compare
Contributor
leonardoce
changed the title
RefreshSecrets errorsRefreshSecrets errors
dosubot
bot
added
the
size:M
Contributor
|
I'm for backporting this, it is a really nice patch |
mnencia
force-pushed
the
dev/reconciler-refactor
branch
from
de2cf87 to
9f04bd7
Compare
mnencia
approved these changes
Apr 9, 2025
Member
|
/ok-to-merge E2E green on EDB fork |
leonardoce
approved these changes
Apr 9, 2025
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
mnencia
force-pushed
the
dev/reconciler-refactor
branch
from
174afc2 to
e0e02ac
Compare
mnencia
changed the title
RefreshSecrets errorsRefreshSecrets
mnencia
added a commit
that referenced
this pull request
Apr 11, 2025
Enhance error handling for the `RefreshSecrets` function across multiple components. Errors are now properly propagated and logged, ensuring that issues during secret refresh operations are surfaced and handled appropriately. Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> (cherry picked from commit 852fdf6)
mnencia
added a commit
that referenced
this pull request
Apr 11, 2025
Enhance error handling for the `RefreshSecrets` function across multiple components. Errors are now properly propagated and logged, ensuring that issues during secret refresh operations are surfaced and handled appropriately. Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> (cherry picked from commit 852fdf6)
mnencia
added a commit
that referenced
this pull request
Apr 11, 2025
Enhance error handling for the `RefreshSecrets` function across multiple components. Errors are now properly propagated and logged, ensuring that issues during secret refresh operations are surfaced and handled appropriately. Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> (cherry picked from commit 852fdf6)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance error handling for the
RefreshSecretsfunction across multiple components. Errors are now properly propagated and logged, ensuring that issues during secret refresh operations are surfaced and handled appropriately.