Collect WAL stats metric from primary only.#9788
Open
redbaron wants to merge 1 commit into
Open
Conversation
dosubot
Bot
added
the
size:S
cnpg-bot
added
backport-requested ◀️
Contributor
|
❗ By default, the pull request is configured to backport to all release branches.
|
dosubot
Bot
added
bug 🐛
pg_stat_wal view shows WAL generation stats and only primary generates WAL. This resolves problem where pg_stat_wal can be empty on a replica which was never a primary before, which causes metric collection to fail on a NULL conversion. Signed-off-by: Maxim Ivanov <maxim@heroiclabs.com>
redbaron
force-pushed
the
no-wal-metric-on-replicas
branch
from
c1056c5 to
1987fab
Compare
jsilvela
approved these changes
Jan 27, 2026
Contributor
Author
|
There was 1.29 release without this fix. Could you please consider merging it for 1.29.1 or 1.30 at least? |
Contributor
Author
|
@gbartolini , @jsilvela , what would it take to merge this in? |
Collaborator
|
a second approval, @redbaron. You already have mine |
|
we are having this problem too. Can this be merged? |
|
I also put another PR to fix the underlying issue (#10624) which allows for NULL values for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pg_stat_wal view shows WAL generation stats and only primary generates WAL.
This resolves problem where pg_stat_wal can be empty on a replica which was never a primary before, which causes metric collection to fail on a NULL conversion.
fixes #9106