fix: don't log full environment variables at default log level #589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:XS
sxd
reviewed
Nov 20, 2025
Member
|
Hi @addreas Can you please fix the DCO problem here please? Regards, |
addreas
force-pushed
the
log-trace-env
branch
from
323f52f to
dcba575
Compare
Contributor
Author
|
DCO is fixed now i think :) |
sxd
approved these changes
Nov 20, 2025
Member
|
@addreas, commitlint complains about the commit message that is not following the conventional commits rules |
mnencia
changed the title
armru
approved these changes
Nov 20, 2025
Signed-off-by: Andreas Mårtensson <andreas.martensson@svt.se>
addreas
force-pushed
the
log-trace-env
branch
from
dcba575 to
e1ab9cf
Compare
Contributor
Author
|
hopefully fixed 🤞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logging the full environment of the plugin container can potentially result in an unnecessarily long log line, but perhaps more importantly the credentials are visible as well.