Scope Secret RBAC for IAM-backed ObjectStores#893
Open
martinohansen wants to merge 1 commit intocloudnative-pg:mainfrom
Open
Scope Secret RBAC for IAM-backed ObjectStores#893martinohansen wants to merge 1 commit intocloudnative-pg:mainfrom
martinohansen wants to merge 1 commit intocloudnative-pg:mainfrom
Conversation
dosubot
Bot
added
size:XS
Avoid granting namespace-wide Secret access when ObjectStores do not need credential Secrets. Ref: cloudnative-pg#892 Signed-off-by: Martin Hansen <dontbeevilpls@gmail.com>
martinohansen
force-pushed
the
fix-secret-rbac
branch
from
4f73a9e to
ea0a7b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
inheritFromIAMRoleis enabledsecretsRole rule when no credential Secret names are collectedFixes #892
Testing
go test ./api/... ./cmd/... ./internal/...