utils: ipset issues

[bzub]

@ryarnyah Could you take a look at these items and tell me if there's a bug or if I'm doing something wrong:

kube-router/utils/ipset.go

Line 169 in 2ac6861

func (ipSet *IPSet) Create(setName string, createOptions ...string) (*Set, error) {

IPSet.Create() adds a Set with a nil pointer, should point to the IPSet object.

kube-router/utils/ipset.go

Line 289 in 2ac6861

_, err := set.runWithStdin(stdin, "restore", "-exist")

The other issue I saw was trying to use Set.Refresh(), the command line would usually be malformed under the call to Restore() linked above. It would end up with Go symbols in the command line like '[hash:net as the type argument. I believe the issue is with the %v printing Go representations of slices in this function:

kube-router/utils/ipset.go

Line 268 in 2ac6861

ipSetRestore += fmt.Sprintf("create %s %v\n", set.Name, set.Options)

Could you also help me understand the workflow for using Save() and Restore() methods? The comments seem more for CLI usage than Go. Thanks for your help!

[ryarnyah]

I will look at this tonight, it seem that there are some flaws in my code. Your analyze seem correct about Create function and about %v. I will push a PR to clean up my mess and add some more Go comment to save and restore.

About save and restore functions, save get current ipsets and build a new ipset struct in memory and restore do the oposite.