Skip to content

Conversation

@roffe
Copy link
Contributor

@roffe roffe commented Jan 14, 2018

After discussions with @SEJeff & @murali-reddy on Slack

  • enriched docs with more reference links to the different components
  • removed https:// part from all-features daemonsets - Thanks @SEJeff for spotting
  • removed static kubeconfig when not running kube-router with service proxy - Thanks @murali-reddy for clarification on how kube-router gets config when service proxy is disabled
  • added notes for req when running containerised kubelet
  • added notes for when running without service-proxy

Would love you input on this PR @SEJeff

@roffe roffe mentioned this pull request Jan 14, 2018
@murali-reddy murali-reddy merged commit 42f7177 into cloudnativelabs:master Jan 14, 2018
@SEJeff
Copy link
Contributor

SEJeff commented Jan 14, 2018

Cleanups that improve are always excellent. Nice job sir!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants