Osxcompat 1 #377
Merged
Osxcompat 1 #377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roffe
commented
Apr 10, 2018
| DEV_SUFFIX?=-git | ||
| BUILD_DATE?=$(shell date --iso-8601) | ||
| OSX=$(filter Darwin,$(shell uname)) | ||
| BUILD_DATE?=$(shell date +%Y-%m-%dT%H:%M:%S%z) |
There was a problem hiding this comment.
Changed to be compat with OSX that does not have the GNU date util
andrewsykim
reviewed
Apr 11, 2018
Makefile
Outdated
| test: gofmt gomoqs ## Runs code quality pipelines (gofmt, tests, coverage, lint, etc) | ||
| go test github.com/cloudnativelabs/kube-router github.com/cloudnativelabs/kube-router/app/... github.com/cloudnativelabs/kube-router/utils/ | ||
| ifeq "$(BUILD_IN_DOCKER)" "true" | ||
| $(DOCKER) run -v $(PWD):/go/src/github.com/cloudnativelabs/kube-router -w /go/src/github.com/cloudnativelabs/kube-router golang:alpine \ |
There was a problem hiding this comment.
I think the docker image here should be at a fixed go version (whatver is being released with kube-router)
There was a problem hiding this comment.
agreed.
if you look at how we compile gobgp further down in the makefile, it's a unspecified docker image there as well that needs to be fixed
I'll add a variable that holds the version for golang:alpine and make sure its used in the whole makefile
|
Locked to golang:1.8.7-alpine, based on what Golang version we built the latest 0.1.0 release with |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adde option to build in Docker, also a small check so it doesn't ask for sudo password for Docker when on OSX
make BUILD_IN_DOCKER=truewill run the go test & kube-router build in golang:alpine, gobgp is already build in docker container.