add service/endpoint event handler for routes controller #384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewsykim
force-pushed
the
routes-informer
branch
4 times, most recently
from
2480759 to
e6709c5
Compare
|
Overall changes look good. Please consider below change in this PR. Its ambiguous to use
A general comment from this PR and #373. I have opened #386 . No need to block this PR on #386. I belive we need to sort out both #386 and #380, after the number of refactors that went in lately. |
andrewsykim
force-pushed
the
routes-informer
branch
2 times, most recently
from
2e1c9fc to
9c21d4d
Compare
|
@murali-reddy used |
andrewsykim
force-pushed
the
routes-informer
branch
from
b65ed5e to
b9fad7e
Compare
|
Thanks @andrewsykim LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.