issue-385: make it optional on which ip address BGP server listens #473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
|
i suggest to introduce bgp-listen-address instead that by default use node ip but allows the users to override with the interface of their chosing to allow for further config in corner case scenarios |
|
@roffe makes sense. Will change the PR |
|
I updated the PR to introudce new per node annotation By default (i.e with no node anntation configures) kube-rotuer continue to configure the GoBGP to listen on the node IP address only. |
…onfigure IP address on which BGP server should lister
murali-reddy
force-pushed
the
issue-385
branch
from
ac7fef4 to
398504a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifying the fix done for #385 in commit 8c746b2
Adding an option
bgp-listen-all-ipto control on which IP GoBGP server listens on. By default value is false, and GoBGP server will just listen on node IP. When set to true GoBGP server will listen on0.0.0.0This flexibility is desinrable when node is multi-homed and GoBGP server can learn routes advertised from different networks.
cc @thoro