cleanup local routes if nexthop moves outside host subnet #629
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bug fix for: #574
We were seeing cases where the route would stick in the kernel routing table after the NextHop for a given service VIP had changed to a node outside of the host's subnet. This happens because there is a gap in the logic where if the NextHop for a given service is not withdrawn but rather transitions to a Kubernetes node outside the subnet of the current host nothing is done with the previously inserted route.
This PR makes it so that kube-router will cleanup lingering routes at the same point that it also cleans up tunnels when the next hop has transitioned to a node outside the subnet of the current host.