Skip to content

Ignore deletion of unknown IPVS rules #830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 16, 2020
Merged

Ignore deletion of unknown IPVS rules #830

merged 1 commit into from
Feb 16, 2020

Conversation

@MrFreezeex
Copy link
Contributor

Add a --service-cidr argument and ignore deletion of IPVS rules not in the service cidr.

Fixes #829

@murali-reddy
Copy link
Member

thanks @MrFreezeex for the PR

I think we will still have problem with service external IP. If some one deploys a service with external IP defined then an IPVS service and endpoints are created in the IPVS. At later point if external IP is removed from the service definition we will still endup having stale ipvs entries

@MrFreezeex
Copy link
Contributor Author

Indeed, this is quite problematic...

After studying the implementation of ipvs in kube-proxy, It appears that they are using an array of excluded CIDR (see https://github.com/kubernetes/kubernetes/blob/f4db8212be53c69a27d893d6a4111422fbce8008/pkg/proxy/ipvs/proxier.go#L2039).

I will rewrite my PR to implement the same kind of behavior, this should do the job.

@murali-reddy
Copy link
Member

array of exclude CIDR sounds good to me.

@MrFreezeex MrFreezeex force-pushed the ignore-ipvs-deletion branch from 2ae22a7 to 0b5afca Compare January 15, 2020 19:10
@MrFreezeex
Copy link
Contributor Author

I changed my code to have an array of excluded cidrs.
Let me know if further changes are needed.

@murali-reddy
Copy link
Member

LGTM

@murali-reddy
Copy link
Member

@MrFreezeex sorry after i approved the PR. There are some conflicts to merge the PR. Can you please rebase. Sorry about that. I would to push this PR in coming release.

@MrFreezeex
Ignore deletion of unknown IPVS rules
c200b84 
* add a --excluded-cidrs
* ignore deletion of ipvs rules with address in excluded cidrs

Signed-off-by: Arthur Outhenin-Chalandre <arthur@cri.epita.fr>
@MrFreezeex
Copy link
Contributor Author

I have rebased my PR.

@murali-reddy murali-reddy merged commit 97c682e into cloudnativelabs:master Feb 16, 2020
@murali-reddy
Copy link
Member

thanks @MrFreezeex

mk01 pushed a commit to mk01/kube-router-ipv6 that referenced this pull request Mar 12, 2020
@MrFreezeex @mk01
Ignore deletion of unknown IPVS rules (cloudnativelabs#830)
f692790 
* add a --excluded-cidrs
* ignore deletion of ipvs rules with address in excluded cidrs

Signed-off-by: Arthur Outhenin-Chalandre <arthur@cri.epita.fr>
(cherry picked from commit 97c682e)
@aauren aauren mentioned this pull request Apr 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@murali-reddy murali-reddy murali-reddy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Avoid removal of IPVS rules not related to kubernetes services

2 participants

@MrFreezeex @murali-reddy