use endpoint (IP, port) tuple to track active endpoints of a service #842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in use. Currently only endpoint IP used so any change in port of the endpoint leaves stale ipvs server config Fixes #841
murali-reddy
requested review from
andrewsykim
and removed request for
andrewsykim
|
@aauren Please review when you get a chance |
mrueg
reviewed
Feb 25, 2020
| namespace string | ||
| clusterIP net.IP | ||
| port int | ||
| targetPort string |
There was a problem hiding this comment.
Why a string type? Shouldn't it have the same type as port?
There was a problem hiding this comment.
TargetPort in service spec is intstr type.
aauren
approved these changes
Feb 28, 2020
This was referenced Apr 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently only endpoint IP used so any change in port of the endpoint leaves stale ipvs server config. With this change (ip, port) tuple is used to track active endpoitns of service and to identify stale IPVS config of server of a service
also service info that is built does not carry
targetportinfo, so any change to justtargetPortin service spec was not trigerring syncFixes #841