Handle missing routing tables #865
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The behavior of iproute2 changed in 5.0 as described in cloudnativelabs#750: now if a table has not been created, `ip route list table <table>` will produce a non-zero exit code. It's not really needed to check tables via `list` anyway, since they will be created by iproute2 when needed on first use. So relax error handling for `ip route list table`, and remove it completely when a table might be missing. This fixes cloudnativelabs#750
|
Ping @murali-reddy @roffe - not sure how the review process works here, but I see you guys have been working on this part of the code. Care to give this a once over? |
|
@ldx Thanks for your PR. Apologies for the delay in the review. Will review the PR |
|
LGTM |
FabienZouaoui
pushed a commit
to SirDataFR/kube-router
that referenced
this pull request
May 11, 2020
The behavior of iproute2 changed in 5.0 as described in cloudnativelabs#750: now if a table has not been created, `ip route list table <table>` will produce a non-zero exit code. It's not really needed to check tables via `list` anyway, since they will be created by iproute2 when needed on first use. So relax error handling for `ip route list table`, and remove it completely when a table might be missing. This fixes cloudnativelabs#750
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The behavior of iproute2 changed in 5.0 as described in #750: now if a
table has not been created,
ip route list table <table>will produce anon-zero exit code.
It's not really needed to check tables via
listanyway, since theywill be created by iproute2 when needed on first use. So relax error
handling for
ip route list table, and remove it completely when atable might be missing.
This fixes #750