Not a complete Vault economy provider

[Azarios]

Hello!

It seems that BankAccounts does not implement the full set of Vault economy methods. For example:

• Vault can detect BankAccounts as an economy provider, but crucial methods like /balance, depositPlayer, or withdrawPlayer are not defined, so Vault-dependent plugins (e.g., Shopkeepers Addon with physical currency) cannot update BankAccounts balances correctly.
• With LiteEco as the Vault provider, these operations work as expected, including admin shops that convert between physical currency and digital balances.

Expected behavior:

• BankAccounts should implement all standard Vault economy methods (getBalance, has, depositPlayer, withdrawPlayer, etc.) so that Vault-dependent plugins fully interact with BankAccounts balances.
• This would allow using BankAccounts as a Vault backend while keeping features like accounts, companies, and future interest calculations functional.

Environment:

• BankAccounts v1.11.1
• Vault v1.7.4
• Spigot/Paper 1.21.10
• Shopkeepers + ShopkeepersAddon (physical currency)

In these screenshots, we can see an inconsistency between vault balances (via LiteEco) and bankAccounts. The correct balance is Vault's. Certain Vault actions not supported by bankAccounts did not change the balance, even though they are supported by LiteEco.

I precise that, before adding LiteEco, I try to use only bankAccounts as Vault economy provider, but since it does not define all the necessary methods, Vault-compatible plugins do not consider it a Vault economy provider (visible in the logs with Shopkeepers, for example: “[15:26:12] [Server thread/ERROR]: [ShopkeepersAddon] No economy provider found! Please install an economy plugin like EssentialsX, CMILib, etc.”).

[zefir-git]

Hello! BankAccounts currently does not support or implement the Vault multi-account or bank system because it is somewhat incompatible with how we handle multiple accounts. But the plugin reports this to Vault with hasBankSupport() -> false, and should not cause unexpected behaviour.

Standard methods such as getBalance, withdrawPlayer, etc. are implemented (here).

From your screenshots, it looks like you have vault enabled in the integrations section in the BankAccounts config, but to be sure, could you please confirm?

BankAccounts/src/main/resources/config.yml

Lines 39 to 45 in ba07f16

	integrations:
	# BankAccounts can work as a Vault economy provider.
	# If enabled, BankAccounts will be the Vault back-end for handling funds.
	# May not work correctly if you have other plugins that *provide* a Vault economy system.
	vault:
	# Whether to enable the Vault integration.
	enabled: false

Something to note is that if you have multiple economy provider plugins, BankAccounts may not be able to hook as the provider. Could you send the full server logs? I think you can also check with /vault-info

In your first screenshot, which plugin do you use to check the balance (where it says [Eco] » Your balance of dollars…)? I will try to replicate this as closely as possible to understand what is happening.

[Azarios]

Hello,

That's right, I activated the Vault integration in BankAccounts configiration, and I don't allow any personal accounts; the players' personal accounts are their accounts linked to Vault.

The link with Vault works well with some plugins (VotingPlugin), as can be seen in the launch logs. But it doesn't work with other plugins (Shopkeepers Addon), which doesn't recognize Vault as an economy provider and therefore deactivates itself.

Whereas with a more “traditional” economic plugin like LiteEco, it works very well (the [Eco] »... is linked to LiteEco), for example, the screenshots where we are in the Shopkeepers interface and the physical currency/digital currency conversion works, is when LiteEco is present in Vault Economy Provider.

BankAccounts do not works with Shopkeepers as Vault economy provider

For comparison with the previous in-game screenshots, where it worked with LiteEco, here are screenshots where only BankAccounts is listed as the Vault economy provider, and where it does not work (/plugins & /vault-info) :

The Shopkeepers Addon interface, which does not work with a digital economy (unlike the previous screenshots where a Vault economy provider was found; here, this is not the case, so the feature is disabled) :

Configuration

Here is my full BankAccounts configuration :

config-bankaccounts.yml

Logs

Here is my full logs trace when I reboot the server :

logs-server-launch.txt

[zefir-git]

Thanks, I understand a bit more what is happening now. When you have both BankAccounts and LiteEco at the same time, different balances are reported by each plugin because I think they are conflicting as economy providers.

When you have only BankAccounts installed (no ShopkeeperAddon), something is causing that plugin to disable itself. I am looking into this.

[zefir-git]

Looking at the ShopkeeperAddon source code, this appears to be a bug in that plugin because it incorrectly checks the economy provider service in plugin load instead of via ServiceRegisterEvent

[Azarios]

Mh, I'm not sure about this understanding, I precise just to be sure, I have Shopkeepers and Shopkeepers Addon installed in all these cases :

• When I only have LiteEco, it works well :
  • Economy provider in vault-info : LiteEco
  • Plugin "Shopkeepers Addon" recognized Vault economy provider : LiteEco
  • Plugin "VotingPlugin" send money by Vault : Credited to LiteEco account
• When I have both LiteEco AND BankAccount :
  • Economy provider in vault-info : LiteEco, BankAccounts
  • Plugin "Shopkeepers Addon" recognized Vault economy provider : LiteEco
  • Plugin "VotingPlugin" send money by Vault : Credited to both LiteEco and BankAccounts (vault) accounts
• When I only have BankAccounts :
  • Economy provider in vault-info : LiteEco and BankAccounts
  • Plugin "Shopkeepers Addon" recognized Vault economy provider : N/A (unrecognized -> Plugin disabled)
  • Plugin "VotingPlugin" send money by Vault : Credited to BankAccounts

Shopkeepers Addon works well with LiteEco and some others Vault compatible plugins, so I don't think the problem is in this plugin.

[zefir-git]

I have examined the source code and I strongly believe the bug is in Shopkeep Addon as it does not properly load the service with a ServiceRegisterEvent, instead the plugin hopes the economy provider will be loaded before it.

LiteEco and other plugins work by random chance as they happen to load before ShopkeepAddon. Any vault provider that loads after it would fail.

I have discussed this with the developer of ShopkeepAddon and have offered to contribute a fix, but they informed me that the repository might be out of date. They might publish a fix themselves.

[zefir-git]

I am closing this as there is nothing to fix in BankAccounts. If you want, I can help you with a workaround or a patch for your ShopkeepAddon plugin jar.

One easy and dirty fix would be to edit the .jar and modify the plugin.yml to add BankAccounts as softdepend, ensuring ShopkeepAddon loads after it. The permissive licence of the plugin allows making such modifications and disassemblies.

The proper way would be to fix this in code by adding the event. I'm happy to write the fix, but I can’t maintain a fork.