Make update script more robust for packer build#467
Merged
alexander-dammeier merged 2 commits intodevelopfrom Jan 22, 2025
Merged
Make update script more robust for packer build#467alexander-dammeier merged 2 commits intodevelopfrom
alexander-dammeier merged 2 commits intodevelopfrom
Conversation
After upgrading to Ubuntu 24.04 the reboot command at the end of the update.sh script does not immediately reboot the machine, which sometimes makes Packer run the next scripts without waiting for the reboot. To prevent this a sleep is added after the reboot command.
alexander-dammeier
requested changes
Jan 22, 2025
Contributor
alexander-dammeier
left a comment
alexander-dammeier
left a comment
There was a problem hiding this comment.
I understand the intention. Maybe a loop is better.
Co-authored-by: Alexander Dammeier <55015726+alexander-dammeier@users.noreply.github.com>
alexander-dammeier
deleted the
feature/more_stable_ubuntu_24.04_packer_build
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After upgrading to Ubuntu 24.04 the reboot command at the end of the update.sh script does not immediately reboot the machine, which sometimes makes Packer run the next scripts without waiting for the reboot. To prevent this a sleep is added after the reboot command.