remove example apps#376
Merged
Merged
Conversation
…lication config with the gop-default values. if your values contain a null value, deepMergeDefaults will ignore that config key and use the default value instead. This is used to prevent unwanted side-effects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will remove our demo/example apps from the repo. Examples are now managed in their own repository at https://github.com/cloudogu/gitops-examples
It also introduces "deepMergeDefaults" as a method of merging user provided gop configs with the default values. This method will ignore all keys from the user provided values which have a value of null and are present and not null in the defaults. This is necessary to prevent unwanted side effects. If you explicitly want to unset default values, you can use an empty string instead of null in your config.