Skip to content

Conversation

@IvoGoman
Copy link
Contributor

Description

organizations with a valid OIDC config will get the oauth2-proxy automatically configured

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Added to documentation?

  • 📜 README.md
  • 🤝 Documentation pages updated
  • 🙅 no documentation needed
  • (if applicable) generated OpenAPI docs for CRD changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@IvoGoman IvoGoman requested a review from a team as a code owner July 18, 2025 15:19
@IvoGoman IvoGoman marked this pull request as draft July 18, 2025 15:42
organizations with a valid OIDC config will get the
oauth2-proxy automatically configured
@IvoGoman IvoGoman force-pushed the feat/ga-oauth2proxy branch from bfa5e61 to 3abcd25 Compare July 21, 2025 15:04
@IvoGoman IvoGoman marked this pull request as ready for review July 21, 2025 16:39
@abhijith-darshan
Copy link
Contributor

We hit some rate limits for kustomize download in actions.

We can remediate this by -

  1. Getting the binary from sigs.k8s.io/kustomize $(call go-get-tool,$(KUSTOMIZE),sigs.k8s.io/kustomize/kustomize/v4@v5.4.3)
  2. Use the kustomize binary already installed by kind setup action.

@IvoGoman IvoGoman merged commit ae967e2 into main Jul 23, 2025
50 of 54 checks passed
@IvoGoman IvoGoman deleted the feat/ga-oauth2proxy branch July 23, 2025 06:53
@IvoGoman
Copy link
Contributor Author

We hit some rate limits for kustomize download in actions.

We can remediate this by -

  1. Getting the binary from sigs.k8s.io/kustomize $(call go-get-tool,$(KUSTOMIZE),sigs.k8s.io/kustomize/kustomize/v4@v5.4.3)
  2. Use the kustomize binary already installed by kind setup action.

The binary download already uses the token if supplied in the env. The download of the kustomize script fails, maybe we can just set the token in the request: https://github.com/cloudoperators/greenhouse/actions/runs/16447817630/job/46514490522#step:2:305

@abhijith-darshan
Copy link
Contributor

I would avoid doing this as it needs changes in Makefile or setting up git config. Simplest thing is to get it from sigs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants